[ 
https://issues.apache.org/jira/browse/HIVE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056611#comment-17056611
 ] 

Hive QA commented on HIVE-23003:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
28s{color} | {color:blue} cli in master has 9 extant Findbugs warnings. {color} 
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
36s{color} | {color:red} cli generated 1 new + 8 unchanged - 1 fixed = 9 total 
(was 9) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 37s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:cli |
|  |  org.apache.hadoop.hive.cli.CliDriver.processCmd1(String) invokes 
System.exit(...), which shuts down the entire virtual machine  At 
CliDriver.java:down the entire virtual machine  At CliDriver.java:[line 146] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21060/dev-support/hive-personality.sh
 |
| git revision | master / 1a3b9bb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21060/yetus/new-findbugs-cli.html
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21060/yetus/patch-asflicense-problems.txt
 |
| modules | C: cli U: cli |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21060/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> CliDriver leaves the session id in the threadname on failure
> ------------------------------------------------------------
>
>                 Key: HIVE-23003
>                 URL: https://issues.apache.org/jira/browse/HIVE-23003
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-23003.01.patch
>
>
> in case the command execution ends with an Exception; the line before the 
> reurrn which supposed to remove the sessionid from the thread name is not 
> removed
> https://github.com/apache/hive/blob/b5de84a6ce27904562bb15d7fe800b6ae3c32670/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java#L209
> impact: in case a lot of failed commands are executed (TestNegativeCliDriver) 
> the sessionid-s are accumulated in the threadname causing  "No more space 
> left on device"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to