[
https://issues.apache.org/jira/browse/HIVE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058418#comment-17058418
]
Hive QA commented on HIVE-23015:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12996552/HIVE-23015.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 18098 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21093/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21093/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21093/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12996552 - PreCommit-HIVE-Build
> Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition
> ---------------------------------------------------------------
>
> Key: HIVE-23015
> URL: https://issues.apache.org/jira/browse/HIVE-23015
> Project: Hive
> Issue Type: Bug
> Components: Vectorization
> Reporter: Peter Vary
> Assignee: Peter Varga
> Priority: Minor
> Attachments: HIVE-23015.patch
>
>
> The _HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED_ is definied like this:
> {code}
> HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED("hive.vectorized.groupby.complex.types.enabled",
> true,
> "This flag should be set to true to enable group by vectorization\n" +
> "of aggregations that use complex types.\n",
> "For example, AVG uses a complex type (STRUCT) for partial aggregation
> results" +
> "The default value is true."),
> {code}
> Notice that the end of the "of aggregations that use complex types.\n" line
> is a "," instead of "+".
> So this will end up using the following constructor using the second sentence
> as an "altName" :)
> {code}
> ConfVars(String varname, Object defaultVal, String description, String
> altName) {
> this(varname, defaultVal, null, description, true, false, altName);
> }
> {code}
> We should fix this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
