[
https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=402769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402769
]
ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/20 10:17
Start Date: 13/Mar/20 10:17
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #949: HIVE-22990
Add file based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r392037676
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -2447,48 +2478,48 @@ public void
testIncrementalRepeatEventOnExistingObject() throws IOException, Int
// INSERT EVENT to unpartitioned table
run("INSERT INTO TABLE " + dbName + ".unptned values('" + unptn_data[0] +
"')", driver);
Tuple replDump = replDumpDb(dbName);
- incrementalDumpList.add(replDump);
Thread.sleep(1000);
// INSERT EVENT to partitioned table with dynamic ADD_PARTITION
run("INSERT INTO TABLE " + dbName + ".ptned PARTITION(b=1) values('" +
ptn_data_1[0] + "')", driver);
+ //Second dump without load will print a warning
+ run("REPL DUMP " + dbName, driverMirror);
+ //Load the previous dump first
Review comment:
This changes the old test case logic. The old test case was expecting the
events to be generated and then load. Any specific reason for this change ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 402769)
Time Spent: 0.5h (was: 20m)
> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
> Key: HIVE-22990
> URL: https://issues.apache.org/jira/browse/HIVE-22990
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch,
> HIVE-22990.03.patch, HIVE-22990.04.patch, HIVE-22990.05.patch,
> HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch,
> HIVE-22990.09.patch, HIVE-22990.10.patch, HIVE-22990.11.patch,
> HIVE-22990.12.patch, HIVE-22990.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
