[ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
----------------------------------
    Description: 
{code:java|title=FetchTask}
public class FetchTask extends Task<FetchWork> implements Serializable {
  private static final long serialVersionUID = 1L;
  private int maxRows = 100;
  private FetchOperator fetch;
  private ListSinkOperator sink;
  private int totalRows;
  private static transient final Logger LOG = 
LoggerFactory.getLogger(FetchTask.class);
  JobConf job = null;
{code}

The Tasks class is base class for many other.  Cleaner to simply make the 
{{Logger}} usable by other classes.

  was:
{code:java|title=FetchTask}
public class FetchTask extends Task<FetchWork> implements Serializable {
  private static final long serialVersionUID = 1L;
  private int maxRows = 100;
  private FetchOperator fetch;
  private ListSinkOperator sink;
  private int totalRows;
  private static transient final Logger LOG = 
LoggerFactory.getLogger(FetchTask.class);
  JobConf job = null;
{code}

There is not need for this {{Logger}} to be transient.  Please remove as it is 
useless overheard.


> Use Inherited Logger in Tasks
> -----------------------------
>
>                 Key: HIVE-23017
>                 URL: https://issues.apache.org/jira/browse/HIVE-23017
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Priority: Minor
>              Labels: n00b, newbie, noob
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task<FetchWork> implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to