[
https://issues.apache.org/jira/browse/HIVE-22997?focusedWorklogId=407005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407005
]
ASF GitHub Bot logged work on HIVE-22997:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 11:50
Start Date: 20/Mar/20 11:50
Worklog Time Spent: 10m
Work Description: anishek commented on pull request #951: HIVE-22997 :
Copy external table to target during Repl Dump operation
URL: https://github.com/apache/hive/pull/951#discussion_r395573595
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestReplDumpTask.java
##########
@@ -127,13 +128,15 @@ public void
removeDBPropertyToPreventRenameWhenBootstrapDumpOfTableFails() throw
private int tableDumpCount = 0;
@Override
- void dumpTable(String dbName, String tblName, String validTxnList, Path
dbRoot, Path replDataDir,
- long lastReplId, Hive hiveDb, HiveWrapper.Tuple<Table>
tuple)
+ List<EximUtil.ReplPathMapping> dumpTable(String dbName, String tblName,
String validTxnList, Path dbRoot,
+ Path replDataDir, long
lastReplId, Hive hiveDb,
+ HiveWrapper.Tuple<Table> tuple)
throws Exception {
tableDumpCount++;
if (tableDumpCount > 1) {
throw new TestException();
}
+ return Collections.EMPTY_LIST;
Review comment:
better to use Collections.emptyList() here and other places, the generic
cast would be provided by this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 407005)
Time Spent: 6h 40m (was: 6.5h)
> Copy external table to target during Repl Dump operation
> --------------------------------------------------------
>
> Key: HIVE-22997
> URL: https://issues.apache.org/jira/browse/HIVE-22997
> Project: Hive
> Issue Type: Task
> Reporter: PRAVIN KUMAR SINHA
> Assignee: PRAVIN KUMAR SINHA
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22997.03.patch, HIVE-22997.04.patch,
> HIVE-22997.1.patch, HIVE-22997.10.patch, HIVE-22997.11.patch,
> HIVE-22997.12.patch, HIVE-22997.13.patch, HIVE-22997.14.patch,
> HIVE-22997.15.patch, HIVE-22997.2.patch, HIVE-22997.4.patch,
> HIVE-22997.5.patch, HIVE-22997.6.patch, HIVE-22997.7.patch,
> HIVE-22997.8.patch, HIVE-22997.9.patch
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
