[ 
https://issues.apache.org/jira/browse/HIVE-23057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063602#comment-17063602
 ] 

Hive QA commented on HIVE-23057:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12997219/HIVE-23057.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 18123 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21197/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21197/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21197/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12997219 - PreCommit-HIVE-Build

> ColumnStatsMergerFactory NPE Possible
> -------------------------------------
>
>                 Key: HIVE-23057
>                 URL: https://issues.apache.org/jira/browse/HIVE-23057
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-23057.1.patch
>
>
> {code:java|title=ColumnStatsMergerFactory.java}
>     // make sure that they have the same type
>     typeNew = typeNew == typeOld ? typeNew : null;
>     switch (typeNew) {
>     case BOOLEAN_STATS:
> {code}
> This will throw a NPE if 'typeNew' does not equal 'typeOld'.  Better to throw 
> an Exception with a helpful error message here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to