[ https://issues.apache.org/jira/browse/HIVE-23064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065813#comment-17065813 ]
David Mollitor commented on HIVE-23064: --------------------------------------- [~pvary] Can never thank you enough for your time. # I will put that back. I think the console log thing needs to be reviewed (thanks for the link) but that is a bigger haul. Beeline should not be using a 'console' logger. It uses SLF4J and shouldn't have a dependency on some other logging system. At the least, we shouldn't be showing server-side stack traces to a remote client. That is confusing to the user (they should get pretty messages) and Hive shouldn't be exposing those internal details to a client (security). # See below # Cool :) {code:java|title=DagUtils.java} // 'fstat' is null FileStatus fstat = null; try { // throws IOException fstat = remoteFs.getFileStatus(file); } catch (IOException e) { // IOException is caught and ignored (swallowed) // 'fstat' is not assigned a value so it still null e.printStackTrace(); } URL resourceURL = ConverterUtils.getYarnUrlFromPath(file); // 'fstat' is null. NPE. long resourceSize = fstat.getLen(); {code} bq. It will throw an IOException that will bubble up to the top. I just do not see how that is possible. > Remove Calls to printStackTrace in Module hive-exec > --------------------------------------------------- > > Key: HIVE-23064 > URL: https://issues.apache.org/jira/browse/HIVE-23064 > Project: Hive > Issue Type: Sub-task > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Major > Attachments: HIVE-23064.1.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)