[
https://issues.apache.org/jira/browse/HIVE-23052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070006#comment-17070006
]
Hive QA commented on HIVE-23052:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998116/HIVE-23052.8.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 49 failed/errored test(s), 18140 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionBogusCatalog[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionByNameBogusCatalog[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionWithAuthBogusCatalog[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionsByNamesBogusCatalog[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.otherCatalog[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesEmptyPartVals[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoDb[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoTable[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNullDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNullTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNullValues[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesWrongNumOfPartVals[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesWrongPart[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValues[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionCaseSensitive[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionEmptyPartName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionIncompletePartName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoDb[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoTable[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNonexistingPart[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNullDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNullPartName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNullTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoEmptyUserGroup[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoPrivilagesSet[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoSuchPart[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullGroups[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullUser[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullValues[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoWrongNumOfPartVals[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfo[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartition[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesEmptyParts[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesNoDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesNoDb[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesNoTable[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesNoTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesNullDbName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesNullNames[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNamesNullTblName[Remote]
(batchId=232)
org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionsByNames[Remote]
(batchId=232)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21316/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21316/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21316/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 49 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12998116 - PreCommit-HIVE-Build
> Optimize lock enqueueing in TxnHandler
> --------------------------------------
>
> Key: HIVE-23052
> URL: https://issues.apache.org/jira/browse/HIVE-23052
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Attachments: HIVE-23052.1.patch, HIVE-23052.2.patch,
> HIVE-23052.3.patch, HIVE-23052.4.patch, HIVE-23052.5.patch,
> HIVE-23052.6.patch, HIVE-23052.7.patch, HIVE-23052.8.patch
>
>
> * Reduce scope of next_lock_id select-for-update by moving the txn_component
> inserts before the S4U + inserting the hive_locks entries before the S4U
> (first with a temp ID, which will be replaced later in a single update). This
> helps decrease the overall time that the next_lock_id table is locked,
> thereby increasing concurrency
> * Insert txn_components in a batch instead of one-by-one (also in
> TxnHandler::addDynamicPartition)
> * Increment next_lock_id and update hive_locks table in a single batch
> statement
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
