[ 
https://issues.apache.org/jira/browse/HIVE-23028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070678#comment-17070678
 ] 

Hive QA commented on HIVE-23028:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998165/HIVE-23028.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 18140 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21328/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21328/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21328/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12998165 - PreCommit-HIVE-Build

> Should not use group parameter when run tests in standalone-metastore-common
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-23028
>                 URL: https://issues.apache.org/jira/browse/HIVE-23028
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zhenyu Zheng
>            Assignee: Zhenyu Zheng
>            Priority: Major
>         Attachments: HIVE-23028.1.patch
>
>
> Should not use group parameter when run tests in standalone-metastore-common
> we inherited the `group` parameter from ‘standalone-metastore’s pom.xml and 
> there the parameter
> is set to : org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest
> ([https://github.com/apache/hive/blob/master/standalone-metastore/pom.xml#L61])
>  which only exists in metastore-server package:
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/annotation/MetastoreUnitTest.java]
> and for tests for metastore-common package does not have the @Catagory header:
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/utils/RetryTest.java]
>  
> and it was actually introduced by:
> [https://github.com/apache/hive/commit/7411d42579ffa0bad96e8da731a1a35afc9ff614#diff-171fcb0dda3bcba577fa13720d5b6571]
> we should remove the group paramenter in 
> [https://github.com/apache/hive/blob/master/standalone-metastore/pom.xml|https://github.com/apache/hive/blob/master/standalone-metastore/pom.xml#L61]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to