[
https://issues.apache.org/jira/browse/HIVE-23098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071954#comment-17071954
]
Hive QA commented on HIVE-23098:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998277/HIVE-23098.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 18141 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21353/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21353/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21353/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12998277 - PreCommit-HIVE-Build
> Allow Operation assertState to Accept a Collection
> --------------------------------------------------
>
> Key: HIVE-23098
> URL: https://issues.apache.org/jira/browse/HIVE-23098
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-23098.1.patch, HIVE-23098.2.patch,
> HIVE-23098.2.patch, HIVE-23098.2.patch, HIVE-23098.3.patch
>
>
> {code:java|title=Operation.java}
> protected final void assertState(List<OperationState> states) throws
> HiveSQLException {
> if (!states.contains(state)) {
> throw new HiveSQLException("Expected states: " + states.toString() + ",
> but found "
> + this.state);
> }
> this.lastAccessTime = System.currentTimeMillis();
> }
> /*********************/
> public void someMethod() {
> assertState(new
> ArrayList<OperationState>(Arrays.asList(OperationState.FINISHED)));
> }
> {code}
> By allowing {{assertState}} to accept a {{Collection}}, one can save an
> allocation and simplify the code:
> {code:java}
> assertState(Collections.singleton(OperationState.FINISHED));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
