[
https://issues.apache.org/jira/browse/HIVE-23096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072101#comment-17072101
]
Naveen Gangam commented on HIVE-23096:
--------------------------------------
Patch looks good to me. +1
Just a quick thought. Should we increase the severity on this message, say to
warn? We have too much logging at info and I wonder if this would be lost.
{code:java}
LOG.info("Result set buffer filled to capacity [{}]", capacity);
{code}
> Review Code Path for getResults
> -------------------------------
>
> Key: HIVE-23096
> URL: https://issues.apache.org/jira/browse/HIVE-23096
> Project: Hive
> Issue Type: Sub-task
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-23096.1.patch
>
>
> * Log when a buffer returned to a client is completely full. This can be
> helpful for identifying misconfigured clients that have a fetchSize that is
> too small
> * See below code snippet
> * Rows are loaded into an ArrayList called "convey." This ArrayList is
> instantiated with the default size (10) and is expanded on-demand as it is
> filled. I changed it so that this ArrayList's size is set once, on the first
> call to fetch, so that it doesn't have to "grow" and waste cycles and memory
> with GC thrashing for that.
> * Some minor cleanup
> {code:java|Driver.java}
> try {
> ss = Utilities.readColumn(driverContext.getResStream(), bos);
> if (bos.getLength() > 0) {
> // use JDK StandardCharsets
> row = new String(bos.getData(), 0, bos.getLength(), "UTF-8");
> } else if (ss == Utilities.StreamStatus.TERMINATED) {
> // Do not create a new string for this. Just use a hard-coded
> empty string. JDK: "Note that use of this constructor is unnecessary since
> Strings are immutable."
> row = new String();
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
