[
https://issues.apache.org/jira/browse/HIVE-23039?focusedWorklogId=413958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413958
]
ASF GitHub Bot logged work on HIVE-23039:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 10:23
Start Date: 01/Apr/20 10:23
Worklog Time Spent: 10m
Work Description: anishek commented on pull request #965: HIVE-23039
Checkpointing for repl dump bootstrap phase
URL: https://github.com/apache/hive/pull/965#discussion_r401496558
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java
##########
@@ -296,4 +300,17 @@ public static boolean includeAcidTableInDump(HiveConf
conf) {
public static boolean tableIncludedInReplScope(ReplScope replScope, String
tableName) {
return ((replScope == null) ||
replScope.tableIncludedInReplScope(tableName));
}
+
+ public static boolean dataCopyCompleted(Path toPath, HiveConf conf) throws
IOException {
+ FileSystem dstFs = null;
+ dstFs = toPath.getFileSystem(conf);
+ if (dstFs.exists(new Path(toPath, ReplUtils.COPY_ACKNOWLEDGEMENT))) {
Review comment:
do return of condition directly rather than using if clause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 413958)
Time Spent: 0.5h (was: 20m)
> Checkpointing for repl dump bootstrap phase
> -------------------------------------------
>
> Key: HIVE-23039
> URL: https://issues.apache.org/jira/browse/HIVE-23039
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23039.01.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)