[ https://issues.apache.org/jira/browse/HIVE-23020?focusedWorklogId=413974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413974 ]
ASF GitHub Bot logged work on HIVE-23020: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Apr/20 10:50 Start Date: 01/Apr/20 10:50 Worklog Time Spent: 10m Work Description: aasha commented on pull request #963: HIVE-23020 : Avoid using _files for replication data copy during incr… URL: https://github.com/apache/hive/pull/963#discussion_r401522879 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java ########## @@ -505,9 +506,8 @@ private static ImportTableDesc getBaseCreateTableDescFromTable(String dbName, Task<?> copyTask = null; if (replicationSpec.isInReplicationScope()) { - boolean isImport = ReplicationSpec.Type.IMPORT.equals(replicationSpec.getReplSpecType()); copyTask = ReplCopyTask.getLoadCopyTask(replicationSpec, dataPath, destPath, x.getConf(), - isAutoPurge, needRecycle, copyToMigratedTxnTable, !isImport); + isAutoPurge, needRecycle, copyToMigratedTxnTable, false); Review comment: Why is this set to false? Do we even need this boolean if everyone is setting it to false? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 413974) Time Spent: 20m (was: 10m) > Avoid using _files for replication data copy during incremental run > ------------------------------------------------------------------- > > Key: HIVE-23020 > URL: https://issues.apache.org/jira/browse/HIVE-23020 > Project: Hive > Issue Type: Task > Reporter: PRAVIN KUMAR SINHA > Assignee: PRAVIN KUMAR SINHA > Priority: Major > Labels: pull-request-available > Attachments: HIVE-23020.01.patch, HIVE-23020.02.patch > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)