[
https://issues.apache.org/jira/browse/HIVE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077329#comment-17077329
]
David Mollitor edited comment on HIVE-23150 at 4/7/20, 3:20 PM:
----------------------------------------------------------------
[~kgyrtkirk] Well, as I see it, the {{TableName}} code also uses split and is
therefore invalid. There should be no splitting anywhere. The only split
should be done in the ANTLR parser.
Also, I have implemented other checks to try to get the project into alignment
with MySQL. I have all the unit tests to go with it.
And I'm not sure what you mean by:
{quote}there are no guarantees that "other parts" don't get a table name with a
'.'
{quote}
What other parts are you referring to? Regardless, this parser is just meant
as Step #1 of several steps to ensure that this works correctly. See:
HIVE-23149
was (Author: belugabehr):
[~kgyrtkirk] Well, as I see it, the {{TableName}} code also uses split and is
therefore invalid. There should be no splitting anywhere. The only split
should be done in the ANTLR parser.
Also, I have implemented other checks to try to get the project into alignment
with MySQL. I have all the unit tests to go with it.
And I'm not sure what you mean by:
{quote}there are no guarantees that "other parts" don't get a table name with a
'.'
{quote}
What other parts are you referring to? Regardless, this parser is just meant
as Step #1 of several steps to ensure that this works correctly.
> Create an Object Identifier Parser for All Components to Use
> ------------------------------------------------------------
>
> Key: HIVE-23150
> URL: https://issues.apache.org/jira/browse/HIVE-23150
> Project: Hive
> Issue Type: Sub-task
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Attachments: HIVE-23150.1.patch
>
>
> Create a parser for parsing (and validating) MySQL/MariaDB style object
> identifiers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
