[ 
https://issues.apache.org/jira/browse/HIVE-23176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081587#comment-17081587
 ] 

David Mollitor commented on HIVE-23176:
---------------------------------------

As I pointed out in [HIVE-23172] once I removed the REGEX rule, quite a few 
unit tests are failing:

{code:none}
Caused by: org.apache.hadoop.hive.ql.parse.ParseException: line 1:7 rule 
Identifier failed predicate: {allowQuotedId()}?
line 1:23 rule Identifier failed predicate: {allowQuotedId()}?
line 1:25 rule Identifier failed predicate: {allowQuotedId()}?
line 1:29 rule Identifier failed predicate: {allowQuotedId()}?
line 1:32 rule Identifier failed predicate: {allowQuotedId()}?
line 1:48 rule Identifier failed predicate: {allowQuotedId()}?
{code}

Because they are now being parsed as an ID (appropriately) whereas they were 
being parsed as a REGEX before.  The tests use quoted strings in the 
identifiers, but {{allowQuotedId()}} is not enabled so the table names don't 
match a valid ID even though they should.

> Remove SELECT REGEX Column Feature
> ----------------------------------
>
>                 Key: HIVE-23176
>                 URL: https://issues.apache.org/jira/browse/HIVE-23176
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-23176.1.patch
>
>
> Remove the Hive feature: REGEX Column.
>  
> Hive has this interesting feature for doing REGEX to SELECT multiple columns. 
>  This needs to go.  It is not SQL standard and as currently implemented, it 
> is impossible to determine if a column identifier is a REGEX or the actual 
> name of the column.  If a column name is enclosed in back ticks then any 
> UTF-8 character is a valid table name.
>  
> [https://dev.mysql.com/doc/refman/8.0/en/identifiers.html]
> [https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Select]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to