[
https://issues.apache.org/jira/browse/HIVE-23194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082994#comment-17082994
]
Hive QA commented on HIVE-23194:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12999836/HIVE-23194.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17411 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21629/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21629/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21629/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12999836 - PreCommit-HIVE-Build
> Use Queue Instead of List for CollectOperator
> ---------------------------------------------
>
> Key: HIVE-23194
> URL: https://issues.apache.org/jira/browse/HIVE-23194
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-23194.1.patch
>
>
> https://github.com/apache/hive/blob/d6948a28ab3e34e5116591a60a96bdf031185e47/ql/src/java/org/apache/hadoop/hive/ql/exec/CollectOperator.java#L85-L88
> {code:java|title=CollectOperator.java}
> rowList = new ArrayList<Object>();
> ...
> } else {
> result.o = rowList.remove(0);
> result.oi = standardRowInspector;
> }
> {code}
> Removing from the head of an {{ArrayList}} is an expensive operation because
> it needs to shift all of the elements down in the array for each call.
> Better to use a {{Queue}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
