[jira] [Commented] (HIVE-11791) Add unit test for HIVE-10122

[Gopal V (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-11791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790699#comment-14790699
 ] 

Gopal V commented on HIVE-11791:
--------------------------------

[~yalovyyi]: Good catch, that look a bit odd - it should be returning just the 
isNull(col1).

The case missing is inside 

{code}
        if (allFalse) {
          return new ExprNodeConstantDesc(Boolean.FALSE);
        }
        // Nothing to compact, update expr with compacted children.
        ((ExprNodeGenericFuncDesc) expr).setChildren(newChildren);
{code}

also FYI, you can annotate the compactExpr method with an @VisibleForTesting 
annotation, so that use from a non-test will trigger a warning during findbugs 
(which I'll re-add today).

> Add unit test for HIVE-10122
> ----------------------------
>
>                 Key: HIVE-11791
>                 URL: https://issues.apache.org/jira/browse/HIVE-11791
>             Project: Hive
>          Issue Type: Test
>          Components: Metastore
>    Affects Versions: 1.1.0
>            Reporter: Illya Yalovyy
>            Assignee: Illya Yalovyy
>            Priority: Minor
>         Attachments: HIVE-11791.patch
>
>
> Unit tests for PartitionPruner.compactExpr()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)