[
https://issues.apache.org/jira/browse/HIVE-23210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085655#comment-17085655
]
Panagiotis Garefalakis commented on HIVE-23210:
-----------------------------------------------
[~rajesh.balamohan] thanks for the sample patch!
While it does solve the particular corner case it does not properly handle the
scenario where there is a comparison between a single-task DAG (wait-time 0)
with a multi-task DAG (1 out of X tasks left with greater wait-time) – In that
case the proposed approach will still return 0 while we should promote the DAG
that waited longer.
I tried to tackle those issues in [^HIVE-23210.02.patch] and added some more
test cases – could you please take a look?
> Fix shortestjobcomparator when jobs submitted have 1 task their vertices
> ------------------------------------------------------------------------
>
> Key: HIVE-23210
> URL: https://issues.apache.org/jira/browse/HIVE-23210
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23210.01.patch, HIVE-23210.02.patch,
> HIVE-23210.wip.patch, TestShortestJobFirstComparator.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In latency sensitive queries, lots of jobs can have vertices with 1 task.
> Currently shortestjobcomparator does not work correctly and returns tasks in
> random order.
> [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/comparator/ShortestJobFirstComparator.java#L51]
> This causes delay in the job runtime. I will attach a simple test case
> shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
