[
https://issues.apache.org/jira/browse/HIVE-23124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085861#comment-17085861
]
Peter Vary commented on HIVE-23124:
-----------------------------------
[~belugabehr]: Quick questions:
* I do not see the value of using Optional instead of just checking null. Can
you share your thoughts why you did this change?
* incrementUserQueries / decrementUserQueries, can we use computeIfAbsent?
* prepare, can we use () -> {} construct instead of new Callable<Void>() {}
Thanks,
Peter
> Review of SQLOperation Class
> ----------------------------
>
> Key: HIVE-23124
> URL: https://issues.apache.org/jira/browse/HIVE-23124
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Attachments: HIVE-23124.1.patch
>
>
> * Use ConcurrentHashMap instead of synchronized methods to improve
> multi-threaded access
> * Use JDK 8 facilities where applicable
> * General cleanup
> * Better log messages and Exception messages
> * Use {{switch}} statement instead of if/else blocks
> * Checkstyle fixes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
