[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati updated HIVE-23088:
--------------------------------
Attachment: HIVE-23088.01.patch
HIVE-23088.01.branch-3.patch
Fix Version/s: 3.1.3
3.2.0
4.0.0
Status: Patch Available (was: Open)
The main issue is from the fact that HookUtils is a public-facing class.
I'm leaving LlapWrappedAppender as is, as it's a log4j-based wrapper with a
bunch of related classes already being used in it.
On branch-3 I've used the already imported StringUtils classes regardless of
commons-lang 2v3, when present.
> Using Strings from log4j breaks non-log4j users
> -----------------------------------------------
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
> Affects Versions: 3.1.2
> Reporter: Vova Vysotskyi
> Assignee: David Lavati
> Priority: Major
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch, HIVE-23088.01.patch
>
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
