[ 
https://issues.apache.org/jira/browse/HIVE-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791382#comment-14791382
 ] 

Ferdinand Xu commented on HIVE-11843:
-------------------------------------

Hi [~spena], the patch LGTM. I have one comment about the patch.
{noformat}
15      select * from newtypestbl where b<=true;        15      select * from 
newtypestbl where b<=true sort by c;
29      select * from newtypestbl where b<=true;        29      select * from 
newtypestbl where b<=true sort by c;
{noformat}
Could you change "sort by c" to "sort by b"? The same as other files in 
parquet_ppd_date.q file, parquet_ppd_decimal.q and parquet_ppd_timestamp.q.

> Add 'sort by c' to Parquet PPD q-tests to avoid different output issues with 
> hadoop-1
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-11843
>                 URL: https://issues.apache.org/jira/browse/HIVE-11843
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>         Attachments: HIVE-11843.1.patch
>
>
> Parquet PPD tests has a different output when is run against hadoop-1 because 
> mixed values are in different order.
> To fix this, we should just add 'sort by c' in the queries that will display 
> mixed values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to