[
https://issues.apache.org/jira/browse/HIVE-23040?focusedWorklogId=426164&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-426164
]
ASF GitHub Bot logged work on HIVE-23040:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/20 13:59
Start Date: 22/Apr/20 13:59
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #977:
URL: https://github.com/apache/hive/pull/977#discussion_r413007694
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -438,16 +450,24 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
String dbName = (null != work.dbNameOrPattern &&
!work.dbNameOrPattern.isEmpty())
? work.dbNameOrPattern
: "?";
- int maxEventLimit = work.maxEventLimit();
replLogger = new IncrementalDumpLogger(dbName, dumpRoot.toString(),
evFetcher.getDbNotificationEventsCount(work.eventFrom, dbName,
work.eventTo, maxEventLimit),
work.eventFrom, work.eventTo, maxEventLimit);
replLogger.startLog();
+ long dumpedCount = resumeFrom - work.eventFrom;
+ if (dumpedCount > 0) {
+ LOG.info("Event id {} to {} are already dumped, skipping {} events",
work.eventFrom, resumeFrom, dumpedCount);
+ }
+ cleanFailedEventDirIfExists(dumpRoot, resumeFrom);
while (evIter.hasNext()) {
NotificationEvent ev = evIter.next();
lastReplId = ev.getEventId();
Path evRoot = new Path(dumpRoot, String.valueOf(lastReplId));
Review comment:
Path creation is not needed for the skipped events. Can be done only for
the new events
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 426164)
Time Spent: 2h (was: 1h 50m)
> Checkpointing for repl dump incremental phase
> ---------------------------------------------
>
> Key: HIVE-23040
> URL: https://issues.apache.org/jira/browse/HIVE-23040
> Project: Hive
> Issue Type: Improvement
> Reporter: Aasha Medhi
> Assignee: PRAVIN KUMAR SINHA
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23040.01.patch, HIVE-23040.02.patch,
> HIVE-23040.03.patch, HIVE-23040.04.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
