[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089770#comment-17089770
]
Hive QA commented on HIVE-23088:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 22s{color}
| {color:red}
/data/hiveptest/logs/PreCommit-HIVE-Build-21851/patches/PreCommit-HIVE-Build-21851.patch
does not apply to master. Rebase required? Wrong Branch? See
http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21851/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Using Strings from log4j breaks non-log4j users
> -----------------------------------------------
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
> Affects Versions: 3.1.2
> Reporter: Vova Vysotskyi
> Assignee: David Lavati
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch,
> HIVE-23088.01.branch-3.patch, HIVE-23088.01.branch-3.patch,
> HIVE-23088.01.patch, HIVE-23088.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
