[ 
https://issues.apache.org/jira/browse/HIVE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092027#comment-17092027
 ] 

Hive QA commented on HIVE-23283:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001063/HIVE-23283.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17141 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21928/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21928/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21928/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13001063 - PreCommit-HIVE-Build

> Generate random temp ID for lock enqueue and commitTxn
> ------------------------------------------------------
>
>                 Key: HIVE-23283
>                 URL: https://issues.apache.org/jira/browse/HIVE-23283
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>         Attachments: HIVE-23283.1.patch
>
>
> In order to optimize the S4U scope of enqueue lock and commitTxn, currently a 
> hardcoded constant (-1) is used to first insert all the lock and ws entries 
> with a temporary lockID/commitID. However, in a concurrent environment this 
> seems to cause some performance degradation (and deadlock issues with some 
> rdbms) as multiple concurrent transactions are trying to insert rows with the 
> same primary key (e.g. (-1, 1), (-1, 2), (-1, 3), .. etc. for (extID/intID) 
> in HIVE_LOCKS). The proposed solution is to replace the constant with a 
> random generated negative number, which seems to resolve this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to