[ 
https://issues.apache.org/jira/browse/HIVE-21304?focusedWorklogId=428009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428009
 ]

ASF GitHub Bot logged work on HIVE-21304:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Apr/20 07:41
            Start Date: 28/Apr/20 07:41
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #994:
URL: https://github.com/apache/hive/pull/994#discussion_r416398587



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -800,6 +800,7 @@ public static TableDesc getTableDesc(String cols, String 
colTypes) {
         serdeConstants.SERIALIZATION_FORMAT, "" + Utilities.ctrlaCode,
         serdeConstants.LIST_COLUMNS, cols,
         serdeConstants.LIST_COLUMN_TYPES, colTypes,
+            hive_metastoreConstants.TABLE_BUCKETING_VERSION, "-1",

Review comment:
       removed the usage of this makeProperties




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 428009)
    Time Spent: 40m  (was: 0.5h)

> Make bucketing version usage more robust
> ----------------------------------------
>
>                 Key: HIVE-21304
>                 URL: https://issues.apache.org/jira/browse/HIVE-21304
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Deepak Jaiswal
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-21304.01.patch, HIVE-21304.02.patch, 
> HIVE-21304.03.patch, HIVE-21304.04.patch, HIVE-21304.05.patch, 
> HIVE-21304.06.patch, HIVE-21304.07.patch, HIVE-21304.08.patch, 
> HIVE-21304.09.patch, HIVE-21304.10.patch, HIVE-21304.11.patch, 
> HIVE-21304.12.patch, HIVE-21304.13.patch, HIVE-21304.14.patch, 
> HIVE-21304.15.patch, HIVE-21304.16.patch, HIVE-21304.17.patch, 
> HIVE-21304.18.patch, HIVE-21304.19.patch, HIVE-21304.20.patch, 
> HIVE-21304.21.patch, HIVE-21304.22.patch, HIVE-21304.23.patch, 
> HIVE-21304.24.patch, HIVE-21304.25.patch, HIVE-21304.26.patch, 
> HIVE-21304.27.patch, HIVE-21304.28.patch, HIVE-21304.29.patch, 
> HIVE-21304.30.patch, HIVE-21304.31.patch, HIVE-21304.32.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> * Show Bucketing version for ReduceSinkOp in explain extended plan - this 
> helps identify what hashing algorithm is being used by by ReduceSinkOp.
> * move the actually selected version to the "conf" so that it doesn't get lost
> * replace trait related logic with a separate optimizer rule
> * do version selection based on a group of operator - this is more reliable
> * skip bucketingversion selection for tables with 1 buckets
> * prefer to use version 2 if possible
> * fix operator creations which didn't set a new conf



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to