[
https://issues.apache.org/jira/browse/HIVE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094899#comment-17094899
]
Hive QA commented on HIVE-23236:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001442/HIVE-23236.4.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21999/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21999/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21999/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2020-04-28 22:16:42.592
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-21999/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2020-04-28 22:16:42.595
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 83a4018 HIVE-23216: Add new api as replacement of
get_partitions_by_expr to return PartitionSpec instead of Partitions (Vineet
Garg, reviewed by Jesus Camacho Rodriguez)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 83a4018 HIVE-23216: Add new api as replacement of
get_partitions_by_expr to return PartitionSpec instead of Partitions (Vineet
Garg, reviewed by Jesus Camacho Rodriguez)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2020-04-28 22:16:43.719
+ rm -rf ../yetus_PreCommit-HIVE-Build-21999
+ mkdir ../yetus_PreCommit-HIVE-Build-21999
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-21999
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-21999/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
Trying to apply the patch with -p0
error: patch failed:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:2429
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java'
cleanly.
Going to apply patch with: git apply -p0
error: patch failed:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:2429
Falling back to three-way merge...
Applied patch to
'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java'
cleanly.
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc2783848949461299822.exe, --version]
libprotoc 2.6.1
protoc-jar: executing: [/tmp/protoc2783848949461299822.exe,
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore,
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources,
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator Version 3.5.2
protoc-jar: executing: [/tmp/protoc6725427903940188305.exe, --version]
libprotoc 2.6.1
ANTLR Parser Generator Version 3.5.2
Output file
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g
org/apache/hadoop/hive/metastore/parser/Filter.g
ANTLR Parser Generator Version 3.5.2
Output file
/data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
org/apache/hadoop/hive/ql/parse/HiveLexer.g
Output file
/data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
org/apache/hadoop/hive/ql/parse/HiveParser.g
log4j:WARN No appenders could be found for logger (DataNucleus.Persistence).
log4j:WARN Please initialize the log4j system properly.
DataNucleus Enhancer (version 4.1.17) for API "JDO"
DataNucleus Enhancer completed with success for 43 classes.
Processing annotations
Annotations processed
Processing annotations
No elements to process
Output file
/data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HintParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g
org/apache/hadoop/hive/ql/parse/HintParser.g
Generating vector expression code
Generating vector expression test code
Processing annotations
Annotations processed
Processing annotations
No elements to process
[ERROR] COMPILATION ERROR :
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[13,1]
package org.openjdk.jmh.annotations does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[14,30]
package org.openjdk.jmh.runner does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[15,30]
package org.openjdk.jmh.runner does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[16,38]
package org.openjdk.jmh.runner.options does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[17,38]
package org.openjdk.jmh.runner.options does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[25,2]
cannot find symbol
symbol: class BenchmarkMode
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[26,2]
cannot find symbol
symbol: class OutputTimeUnit
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[27,2]
cannot find symbol
symbol: class State
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[28,2]
cannot find symbol
symbol: class Warmup
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[29,2]
cannot find symbol
symbol: class Measurement
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[44,51]
cannot find symbol
symbol: class RunnerException
location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[32,6]
cannot find symbol
symbol: class Param
location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[34,6]
cannot find symbol
symbol: class Param
location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[36,6]
cannot find symbol
symbol: class Param
location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[38,6]
cannot find symbol
symbol: class Param
location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[53,6]
cannot find symbol
symbol: class Setup
location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[97,6]
cannot find symbol
symbol: class TearDown
location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[103,6]
cannot find symbol
symbol: class Benchmark
location: class org.apache.TxnHandlerBenchRunner
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile)
on project hive-exec: Compilation failure: Compilation failure:
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[13,1]
package org.openjdk.jmh.annotations does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[14,30]
package org.openjdk.jmh.runner does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[15,30]
package org.openjdk.jmh.runner does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[16,38]
package org.openjdk.jmh.runner.options does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[17,38]
package org.openjdk.jmh.runner.options does not exist
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[25,2]
cannot find symbol
[ERROR] symbol: class BenchmarkMode
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[26,2]
cannot find symbol
[ERROR] symbol: class OutputTimeUnit
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[27,2]
cannot find symbol
[ERROR] symbol: class State
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[28,2]
cannot find symbol
[ERROR] symbol: class Warmup
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[29,2]
cannot find symbol
[ERROR] symbol: class Measurement
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[44,51]
cannot find symbol
[ERROR] symbol: class RunnerException
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[32,6]
cannot find symbol
[ERROR] symbol: class Param
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[34,6]
cannot find symbol
[ERROR] symbol: class Param
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[36,6]
cannot find symbol
[ERROR] symbol: class Param
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[38,6]
cannot find symbol
[ERROR] symbol: class Param
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[53,6]
cannot find symbol
[ERROR] symbol: class Setup
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[97,6]
cannot find symbol
[ERROR] symbol: class TearDown
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/TxnHandlerBenchRunner.java:[103,6]
cannot find symbol
[ERROR] symbol: class Benchmark
[ERROR] location: class org.apache.TxnHandlerBenchRunner
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :hive-exec
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-21999
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13001442 - PreCommit-HIVE-Build
> Remove the global lock from acquireLock
> ---------------------------------------
>
> Key: HIVE-23236
> URL: https://issues.apache.org/jira/browse/HIVE-23236
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Attachments: HIVE-23236.1.patch, HIVE-23236.2.patch,
> HIVE-23236.2.patch, HIVE-23236.3.patch, HIVE-23236.4.patch
>
>
> Currently we have a global lock (NEXT_LOCK_ID) when running enqueueLock,
> because the algorithm in checkLock requires the locks to have a well defined
> order, and also requires that every lock component is already stored in the
> RDBMS before checking the locks.
> Proposed approach:
> * Enqueue locks without a global S4U lock, using an auto-incremented value
> instead to get the next lock ID (modify next_lock_id table)
> * Before checking for lock conflicts, issue a S4U for all lock components we
> are requesting (db/table/partition level) in order to prevent other clients
> for doing interleaving conflict check (especially late-coming clients holding
> a lower lockID)
> * Conflict check algorithm to check not just for lower lockIDs, but also
> higher lockIDs which are already in 'acquired' state
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
