[
https://issues.apache.org/jira/browse/HIVE-23323?focusedWorklogId=430327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430327
]
ASF GitHub Bot logged work on HIVE-23323:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/20 17:44
Start Date: 04/May/20 17:44
Worklog Time Spent: 10m
Work Description: miklosgergely commented on a change in pull request
#1000:
URL: https://github.com/apache/hive/pull/1000#discussion_r419610881
##########
File path: itests/qtest-spark/pom.xml
##########
@@ -417,5 +417,53 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
Review comment:
Please use 2 spaces as indentation, to keep consistency
##########
File path: itests/qtest/pom.xml
##########
@@ -426,15 +426,62 @@
<scope>test</scope>
</dependency>
</dependencies>
- <profiles>
- <profile>
- <!-- replaces -Dclustermode=minimr which I am sure sure was used? -->
- <id>minimr</id>
- <properties>
- <test.warehouse.scheme></test.warehouse.scheme>
- </properties>
- </profile>
- </profiles>
+ <profiles>
Review comment:
Please use 2 spaces as indentation, to keep consistency
##########
File path:
itests/util/src/test/java/org/apache/hadoop/hive/cli/control/TestSplitSupport.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.cli.control;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.junit.Test;
+
+import com.google.common.collect.Sets;
+
+public class TestSplitSupport {
+
+ @Test
+ public void testSplitParams() {
Review comment:
What is this test for?
##########
File path: itests/bin/generate-cli-splits.sh
##########
@@ -0,0 +1,26 @@
+#!/bin/bash
+
+usage() {
+ echo "$0 <from> <to>"
+ exit 1
+}
+
+[ "$1" == "" ] && usage
+[ "$2" == "" ] && usage
+
+
+inDir="$1"
+outDir="$2"
+
+git grep SplitSupport.process | grep "$1" | cut -d ':' -f1|while read f;do
Review comment:
Nit: Please be consistent about putting two spaces next to the |
characters when they are used as pipeline separators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 430327)
Time Spent: 0.5h (was: 20m)
> Add qsplits profile
> -------------------
>
> Key: HIVE-23323
> URL: https://issues.apache.org/jira/browse/HIVE-23323
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23323.01.patch, HIVE-23323.02.patch,
> HIVE-23323.02.patch, HIVE-23323.02.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> provide an in-maven way to split-up big testclasses into smaller ones
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
