[
https://issues.apache.org/jira/browse/HIVE-22017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124470#comment-17124470
]
Vihang Karajgaonkar commented on HIVE-22017:
--------------------------------------------
The patch looks good to me. Can you fix the checkstyle issues?
{noformat}
./standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java:27:import
org.apache.hadoop.hive.common.ValidTxnWriteIdList;:8: warning: Unused import -
org.apache.hadoop.hive.common.ValidTxnWriteIdList.
./standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java:31:import
org.apache.hadoop.hive.metastore.api.*;: warning: Using the '.*' form of
import should be avoided - org.apache.hadoop.hive.metastore.api.*.
./standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java:26:import
org.apache.hadoop.hive.common.ValidTxnWriteIdList;:8: warning: Unused import -
org.apache.hadoop.hive.common.ValidTxnWriteIdList.
./standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java:30:import
org.apache.hadoop.hive.metastore.api.*;: warning: Using the '.*' form of
import should be avoided - org.apache.hadoop.hive.metastore.api.*.
./standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:1456:
List<String> part_names):60:
warning: Name 'part_names' must match pattern '^[a-z][a-zA-Z0-9]*$'.
./standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:3495:
("getFieldsRequest is not supported in HiveMetastoreClientPreCatalog.
Use HiveMetastoreClient instead");: warning: 'operator new lparen' have
incorrect indentation level 8, expected level should be 4.
./standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:3495:
("getFieldsRequest is not supported in HiveMetastoreClientPreCatalog.
Use HiveMetastoreClient instead");:9: warning: '(' should be on the previous
line.
{noformat}
> [ Interface changes ] Keep HMS interfaces backward compatible with changes
> for HIVE-21637
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-22017
> URL: https://issues.apache.org/jira/browse/HIVE-22017
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 2.3.7
> Reporter: Daniel Dai
> Assignee: Kishen Das
> Priority: Major
> Attachments: HIVE-22017.1.patch, HIVE-22017.2.patch,
> HIVE-22017.3.patch, HIVE-22017.4.patch, HIVE-22017.5.patch, HIVE-22017.6.patch
>
>
> As part of HIVE-21637 we would have to introduce ValidWriteIdList in several
> methods. Also, in the long term, we should deprecate and remove all the
> methods that take direct arguments, as the service definition keeps changing
> whenever we add/remove arguments, making it hard to maintain backward
> compatibility. So, instead of adding writeId in bunch of get_xxx calls that
> take direct arguments, we will create new set of methods that take Request
> object and return Response object. We shall mark those deprecated and remove
> in future version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
