[
https://issues.apache.org/jira/browse/HIVE-20890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125006#comment-17125006
]
Hive QA commented on HIVE-20890:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13004704/HIVE-20890.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 17094 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_no_buckets]
(batchId=100)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_stats3]
(batchId=43)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_stats4]
(batchId=92)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_table_stats]
(batchId=84)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explain_locks]
(batchId=74)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=94)
org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCompactStatsGather (batchId=273)
org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCompactStatsGather
(batchId=274)
org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testForParallelBootstrapLoad
(batchId=182)
org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testMetadataOnlyDump
(batchId=182)
org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testNonParallelBootstrapLoad
(batchId=182)
org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosMMNoAutogather.testRetryFailure
(batchId=182)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testAllPartitions
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testNoStatsUpdateForSimpleReplTable
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testNoStatsUpdateForTxnReplTable
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testParallelOps
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testPartitionSubset
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testPartitionsWithDifferentColsAll
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testPartitionsWithDifferentColsExistingOnly
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testQueueingWithThreads
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testTxnDynamicPartitions
(batchId=257)
org.apache.hadoop.hive.ql.stats.TestStatsUpdaterThread.testTxnPartitions
(batchId=257)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testStatsAfterCompactionPartTbl
(batchId=178)
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testParallelCompilation (batchId=219)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22729/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22729/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22729/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 24 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13004704 - PreCommit-HIVE-Build
> ACID: Allow whole table ReadLocks to skip all partition locks
> -------------------------------------------------------------
>
> Key: HIVE-20890
> URL: https://issues.apache.org/jira/browse/HIVE-20890
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Reporter: Gopal Vijayaraghavan
> Assignee: Denys Kuzmenko
> Priority: Major
> Attachments: HIVE-20890.1.patch
>
>
> HIVE-19369 proposes adding a EXCL_WRITE lock which does not wait for any
> SHARED_READ locks for read operations - in the presence of that lock, the
> insert overwrite no longer takes an exclusive lock.
> The only exclusive operation will be a schema change or drop table, which
> should take an exclusive lock on the entire table directly.
> {code}
> explain locks select * from tpcds_bin_partitioned_orc_1000.store_sales where
> ss_sold_date_sk=2452626
> +----------------------------------------------------+
> | Explain |
> +----------------------------------------------------+
> | LOCK INFORMATION: |
> | tpcds_bin_partitioned_orc_1000.store_sales -> SHARED_READ |
> | tpcds_bin_partitioned_orc_1000.store_sales.ss_sold_date_sk=2452626 ->
> SHARED_READ |
> +----------------------------------------------------+
> {code}
> So the per-partition SHARED_READ locks are no longer necessary, if the lock
> builder already includes the table-wide SHARED_READ locks.
> The removal of entire partitions is the only part which needs to be taken
> care of within this semantics as row-removal instead of directory removal
> (i.e "drop partition" -> "truncate partition" and have the truncation trigger
> a whole directory cleaner, so that the partition disappears when there are 0
> rows left).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
