[
https://issues.apache.org/jira/browse/HIVE-23629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127422#comment-17127422
]
Mustafa Iman commented on HIVE-23629:
-------------------------------------
Thanks [~pgaref] for creating the other pipeline and giving my PR a run. Seems
like it failed as expected. You can see in the
logs([http://130.211.9.232/job/panos-precommit/3/consoleFull)] which findbugs
rules are violated. I think that is enough for a report:
{code:java}
12:01:46 [INFO] --- findbugs-maven-plugin:3.0.5:check (default-cli) @
hive-shims-common ---
12:01:46 [INFO] BugInstance size is 6
12:01:46 [INFO] Error size is 0
12:01:46 [INFO] Total bugs: 6
12:01:46 [INFO] Unread public/protected field:
org.apache.hadoop.fs.ProxyFileSystem.realUri
[org.apache.hadoop.fs.ProxyFileSystem] At ProxyFileSystem.java:[line 107]
URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
12:01:46 [INFO] Dead store to nameUriString in
org.apache.hadoop.fs.ProxyLocalFileSystem.initialize(URI, Configuration)
[org.apache.hadoop.fs.ProxyLocalFileSystem] At ProxyLocalFileSystem.java:[line
61] DLS_DEAD_LOCAL_STORE
12:01:46 [INFO] input must be non-null but is marked as nullable
[org.apache.hadoop.hive.io.HdfsUtils$1] At HdfsUtils.java:[lines 179-182]
NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE
12:01:46 [INFO] org.apache.hadoop.hive.shims.CombineHiveKey defines
compareTo(Object) and uses Object.equals()
[org.apache.hadoop.hive.shims.CombineHiveKey] At CombineHiveKey.java:[lines
51-52] EQ_COMPARETO_USE_OBJECT_EQUALS
12:01:46 [INFO] Unread public/protected field:
org.apache.hadoop.hive.shims.HadoopShimsSecure$CombineFileRecordReader.rrClass
[org.apache.hadoop.hive.shims.HadoopShimsSecure$CombineFileRecordReader] At
HadoopShimsSecure.java:[line 196] URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
12:01:46 [INFO] Unused public or protected field:
org.apache.hadoop.hive.shims.HadoopShimsSecure$CombineFileRecordReader.fs
[org.apache.hadoop.hive.shims.HadoopShimsSecure$CombineFileRecordReader] In
HadoopShimsSecure.java UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD
12:01:46 [INFO]
{code}
I fixed those 6 issues in another PR and restarted the test. If this one
passes, I think we can merge the findbugs check to master.
> Enforce clean findbugs in PRs
> -----------------------------
>
> Key: HIVE-23629
> URL: https://issues.apache.org/jira/browse/HIVE-23629
> Project: Hive
> Issue Type: Sub-task
> Reporter: Mustafa Iman
> Assignee: Mustafa Iman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should start enforcing clean findbugs reports as soon as we fix a module.
> Otherwise, it will continue collecting findbugs errors. We can add a stage to
> Jenkins pipeline to enforce findbugs and possibly other checks. It will
> selectively run findbugs for specified sub modules. Eventually we can get rid
> of the list and enable findbugs for the whole project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
