[
https://issues.apache.org/jira/browse/HIVE-23629?focusedWorklogId=442778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442778
]
ASF GitHub Bot logged work on HIVE-23629:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 15:57
Start Date: 09/Jun/20 15:57
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #1069:
URL: https://github.com/apache/hive/pull/1069#issuecomment-641196475
> If we are aiming to enforce clean findbugs in every pull request, I dont
see much benefit in having a findbugs report. It is going to be empty all the
time apart from the bugs you might introduce in your patch.
I was thinking that it could be used to publish the errors (if there are
any) - it's easier to view it on the jenkins... but it can be skipped...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 442778)
Time Spent: 1h 20m (was: 1h 10m)
> Enforce clean findbugs in PRs
> -----------------------------
>
> Key: HIVE-23629
> URL: https://issues.apache.org/jira/browse/HIVE-23629
> Project: Hive
> Issue Type: Sub-task
> Reporter: Mustafa Iman
> Assignee: Mustafa Iman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We should start enforcing clean findbugs reports as soon as we fix a module.
> Otherwise, it will continue collecting findbugs errors. We can add a stage to
> Jenkins pipeline to enforce findbugs and possibly other checks. It will
> selectively run findbugs for specified sub modules. Eventually we can get rid
> of the list and enable findbugs for the whole project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
