[
https://issues.apache.org/jira/browse/HIVE-23026?focusedWorklogId=442870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442870
]
ASF GitHub Bot logged work on HIVE-23026:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 16:07
Start Date: 09/Jun/20 16:07
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1080:
URL: https://github.com/apache/hive/pull/1080#discussion_r437518709
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
##########
@@ -317,7 +317,8 @@ protected void openInternal(final HiveConf conf,
Collection<String> additionalFi
setupSessionAcls(tezConfig, conf);
- final TezClient session = TezClient.newBuilder("HIVE-" + sessionId,
tezConfig)
+ String tezJobName = HiveConf.getVar(conf, ConfVars.HIVETEZJOBNAME,
sessionId);
+ final TezClient session = TezClient.newBuilder(String.format("HIVE-%s",
tezJobName), tezConfig)
Review comment:
Here is what I am suggesting:
```
String tezJobNameFormat = HiveConf.getVar(conf, ConfVars.HIVETEZJOBNAME);
final TezClient session =
TezClient.newBuilder(String.format(tezJobNameFormat, sessionId), tezConfig)
```
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -1500,6 +1500,9 @@ private static void populateLlapDaemonVarsSet(Set<String>
llapDaemonVarsSetLocal
HIVEQUERYNAME ("hive.query.name", null,
"This named is used by Tez to set the dag name. This name in turn will
appear on \n" +
"the Tez UI representing the work that was done."),
+ HIVETEZJOBNAME("tez.job.name", null,
Review comment:
The second value here, I believe is a 'default' value. The default
should be `HIVE-%s`. Also please update comments to explain how this works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 442870)
Time Spent: 40m (was: 0.5h)
> support add a yarn application name for tez on hiveserver2
> ----------------------------------------------------------
>
> Key: HIVE-23026
> URL: https://issues.apache.org/jira/browse/HIVE-23026
> Project: Hive
> Issue Type: Improvement
> Components: Tez
> Affects Versions: 2.0.0
> Reporter: Jake Xie
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0, 3.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently tez on hiveServer2 cannot specify yarn application name, which is
> not very convenient for locating the problem SQL, so i added a configuration
> item to support setting tez job name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
