[
https://issues.apache.org/jira/browse/HIVE-23539?focusedWorklogId=444295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444295
]
ASF GitHub Bot logged work on HIVE-23539:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/20 14:40
Start Date: 11/Jun/20 14:40
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1084:
URL: https://github.com/apache/hive/pull/1084#discussion_r438836524
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
##########
@@ -243,29 +246,34 @@ private void addPartition(boolean hasMorePartitions,
AlterTableAddPartitionDesc
: LoadFileType.OVERWRITE_EXISTING);
stagingDir =
PathUtils.getExternalTmpPath(replicaWarehousePartitionLocation,
context.pathInfo);
}
-
- Task<?> copyTask = ReplCopyTask.getLoadCopyTask(
- event.replicationSpec(),
- new Path(event.dataPath() + Path.SEPARATOR +
getPartitionName(sourceWarehousePartitionLocation)),
- stagingDir,
- context.hiveConf, false, false
- );
-
+ Path partDataSrc = new Path(event.dataPath() + File.separator +
getPartitionName(sourceWarehousePartitionLocation));
Review comment:
Normally yes, but in this case it will not as
getPartitionName(sourceWarehousePartitionLocation) returns value with /
attached. Path will take that itself as final path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 444295)
Time Spent: 0.5h (was: 20m)
> Optimize data copy during repl load operation for HDFS based staging location
> -----------------------------------------------------------------------------
>
> Key: HIVE-23539
> URL: https://issues.apache.org/jira/browse/HIVE-23539
> Project: Hive
> Issue Type: Improvement
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23539.01.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
