[
https://issues.apache.org/jira/browse/HIVE-23751?focusedWorklogId=449715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449715
]
ASF GitHub Bot logged work on HIVE-23751:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/20 10:07
Start Date: 23/Jun/20 10:07
Worklog Time Spent: 10m
Work Description: shameersss1 opened a new pull request #1167:
URL: https://github.com/apache/hive/pull/1167
HADOOP-16582 have changed the way how mkdirs() work:
Before HADOOP-16582:
All calls to mkdirs(p) were fast-tracked to FileSystem.mkdirs which were
then re-routed to mkdirs(p, permission) method. For ProxyFileSytem the call
would look like
FileUtiles.mkdir(p) -----> FileSystem.mkdirs(p) --->
ProxyFileSytem.mkdirs(p,permission)
An implementation of FileSystem have only needed implement mkdirs(p,
permission)
After HADOOP-16582:
Since FilterFileSystem overrides mkdirs(p) method the new call to
ProxyFileSystem would look like
FileUtiles.mkdir(p) ---> FilterFileSystem.mkdirs(p) -->
This will make all the qtests fails with the below exception
Caused by: java.lang.IllegalArgumentException: Wrong FS:
pfile:/media/ebs1/workspace/hive-3.1-qtest/group/5/label/HiveQTest/hive-1.2.0/itests/qtest/target/warehouse/dest1,
expected: file:///
Note: We will hit this issue when we bump up hadoop version in hive.
So as per the discussion in HADOOP-16963 ProxyFileSystem would need to
override the mkdirs(p) method inorder to solve the above problem. So now the
new flow would look like
FileUtiles.mkdir(p) ----> ProxyFileSytem.mkdirs(p) --->
ProxyFileSytem.mkdirs(p, permission) --->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 449715)
Remaining Estimate: 0h
Time Spent: 10m
> QTest: Override #mkdirs() method in ProxyFileSystem To Align After
> HADOOP-16582
> -------------------------------------------------------------------------------
>
> Key: HIVE-23751
> URL: https://issues.apache.org/jira/browse/HIVE-23751
> Project: Hive
> Issue Type: Task
> Reporter: Syed Shameerur Rahman
> Assignee: Syed Shameerur Rahman
> Priority: Major
> Fix For: 4.0.0, 3.2.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HADOOP-16582 have changed the way how mkdirs() work:
> *Before HADOOP-16582:*
> All calls to mkdirs(p) were fast-tracked to FileSystem.mkdirs which were then
> re-routed to mkdirs(p, permission) method. For ProxyFileSytem the call would
> look like
> {code:java}
> FileUtiles.mkdir(p) -----> FileSystem.mkdirs(p) --->
> ProxyFileSytem.mkdirs(p,permission)
> {code}
> An implementation of FileSystem have only needed implement mkdirs(p,
> permission)
> *After HADOOP-16582:*
> Since FilterFileSystem overrides mkdirs(p) method the new call to
> ProxyFileSystem would look like
> {code:java}
> FileUtiles.mkdir(p) ---> FilterFileSystem.mkdirs(p) -->
> {code}
> This will make all the qtests fails with the below exception
> {code:java}
> Caused by: java.lang.IllegalArgumentException: Wrong FS:
> pfile:/media/ebs1/workspace/hive-3.1-qtest/group/5/label/HiveQTest/hive-1.2.0/itests/qtest/target/warehouse/dest1,
> expected: file:///
> {code}
> Note: We will hit this issue when we bump up hadoop version in hive.
> So as per the discussion in HADOOP-16963 ProxyFileSystem would need to
> override the mkdirs(p) method inorder to solve the above problem. So now the
> new flow would look like
> {code:java}
> FileUtiles.mkdir(p) ----> ProxyFileSytem.mkdirs(p) --->
> ProxyFileSytem.mkdirs(p, permission) --->
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
