[ 
https://issues.apache.org/jira/browse/HIVE-23737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149414#comment-17149414
 ] 

Syed Shameerur Rahman commented on HIVE-23737:
----------------------------------------------

Added unit tests in HIVE-23737.02.patch

> LLAP: Reuse dagDelete Feature Of Tez Custom Shuffle Handler Instead Of LLAP's 
> dagDelete
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-23737
>                 URL: https://issues.apache.org/jira/browse/HIVE-23737
>             Project: Hive
>          Issue Type: Improvement
>          Components: llap
>            Reporter: Syed Shameerur Rahman
>            Assignee: Syed Shameerur Rahman
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23737.01.patch, HIVE-23737.02.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> LLAP have a dagDelete feature added as part of HIVE-9911, But now that Tez 
> have added support for dagDelete in custom shuffle handler (TEZ-3362) we 
> could re-use that feature in LLAP. 
> There are some added advantages of using Tez's dagDelete feature rather than 
> the current LLAP's dagDelete feature.
> 1) We can easily extend this feature to accommodate the upcoming features 
> such as vertex and failed task attempt shuffle data clean up. Refer TEZ-3363 
> and TEZ-4129
> 2) It will be more easier to maintain this feature by separating it out from 
> the Hive's code path. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to