[
https://issues.apache.org/jira/browse/HIVE-23727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140552#comment-17140552
]
Zhihua Deng edited comment on HIVE-23727 at 7/1/20, 2:52 PM:
-------------------------------------------------------------
In a busy env, the operation may be pended(asyncPrepare is enabled), so it's
better to change the condition from if (shouldRunAsync() && state !=
OperationState.CANCELED && state != OperationState.TIMEDOUT) to if
(shouldRunAsync() && oldState == OperationState.PENDING).
was (Author: dengzh):
In a busy env, the operation may be pended(asyncPrepare is enabled), so it's
better to change the condition from _if (shouldRunAsync() && state !=
OperationState.CANCELED && state != OperationState.TIMEDOUT)_ to _if
(shouldRunAsync() && oldState == OperationState.PENDING__)._
> Improve SQLOperation log handling when cleanup
> ----------------------------------------------
>
> Key: HIVE-23727
> URL: https://issues.apache.org/jira/browse/HIVE-23727
> Project: Hive
> Issue Type: Improvement
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The SQLOperation checks _if (shouldRunAsync() && state !=
> OperationState.CANCELED && state != OperationState.TIMEDOUT)_ to cancel the
> background task. If true, the state should not be OperationState.CANCELED, so
> logging under the state == OperationState.CANCELED should never happen.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
