ASF GitHub Bot logged work on HIVE-23791:

                Author: ASF GitHub Bot
            Created on: 01/Jul/20 16:19
            Start Date: 01/Jul/20 16:19
    Worklog Time Spent: 10m 
      Work Description: pvargacl commented on a change in pull request #1196:
URL: https://github.com/apache/hive/pull/1196#discussion_r448474859

File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
@@ -1305,7 +1322,9 @@ public static Directory getAcidState(FileSystem 
fileSystem, Path candidateDirect
             bestBase, ignoreEmptyFiles, abortedDirectories, fs, validTxnList);
     } else {
-      dirSnapshots = getHdfsDirSnapshots(fs, candidateDirectory);
+      if (dirSnapshots == null) {

Review comment:
       There is a slight problem here, if we are on hdfs and the file listing 
with id is supported. Few lines below there is a check for dirsnapshot == null, 
that was running every time for this case, but now it won't run if you call 
getacidstate with nonnull dirsnapshot

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 453499)
    Time Spent: 20m  (was: 10m)

> Optimize ACID stats generation
> ------------------------------
>                 Key: HIVE-23791
>                 URL: https://issues.apache.org/jira/browse/HIVE-23791
>             Project: Hive
>          Issue Type: Improvement
>          Components: Statistics, Transactions
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
> Currently basic stats generation uses file listing for getting statistics, 
> and also uses a file listing for getting the acid state. We should optimize 
> this.

This message was sent by Atlassian Jira

Reply via email to