[
https://issues.apache.org/jira/browse/HIVE-23525?focusedWorklogId=455409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455409
]
ASF GitHub Bot logged work on HIVE-23525:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/20 12:22
Start Date: 07/Jul/20 12:22
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1219:
URL: https://github.com/apache/hive/pull/1219#discussion_r450822761
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/txn/TestAcidTxnCleanerService.java
##########
@@ -148,16 +149,16 @@ public void cleansEmptyAbortedBatchTxns() throws
Exception {
TxnStore.TIMED_OUT_TXN_ABORT_BATCH_SIZE + 50);
OpenTxnsResponse resp = txnHandler.openTxns(new OpenTxnRequest(
TxnStore.TIMED_OUT_TXN_ABORT_BATCH_SIZE + 50, "user", "hostname"));
+ txnHandler.setOpenTxnTimeOutMillis(1);
txnHandler.abortTxns(new AbortTxnsRequest(resp.getTxn_ids()));
GetOpenTxnsResponse openTxns = txnHandler.getOpenTxns();
Assert.assertEquals(TxnStore.TIMED_OUT_TXN_ABORT_BATCH_SIZE + 50 + 1,
openTxns.getOpen_txnsSize());
- txnHandler.setOpenTxnTimeOutMillis(1);
underTest.run();
openTxns = txnHandler.getOpenTxns();
Assert.assertEquals(2, openTxns.getOpen_txnsSize());
- Assert.assertEquals(TxnStore.TIMED_OUT_TXN_ABORT_BATCH_SIZE + 50 + 1,
getMaxTxnId());
+ Assert.assertTrue("The max txnId shoul be at least", getMaxTxnId() >=
TxnStore.TIMED_OUT_TXN_ABORT_BATCH_SIZE + 50 + 1);
Review comment:
nit: should
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455409)
Time Spent: 0.5h (was: 20m)
> TestAcidTxnCleanerService is unstable
> -------------------------------------
>
> Key: HIVE-23525
> URL: https://issues.apache.org/jira/browse/HIVE-23525
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23525.1.patch, HIVE-23525.2.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> from time to time this exception happens
> http://34.66.156.144:8080/job/hive-c/7/console
> {code}
> 15:03:41 [INFO]
> 15:03:41 [INFO] -------------------------------------------------------
> 15:03:41 [INFO] T E S T S
> 15:03:41 [INFO] -------------------------------------------------------
> 15:03:42 [INFO] Running
> org.apache.hadoop.hive.metastore.txn.TestAcidTxnCleanerService
> 15:04:10 [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed: 25.582 s <<< FAILURE! - in
> org.apache.hadoop.hive.metastore.txn.TestAcidTxnCleanerService
> 15:04:10 [ERROR]
> cleansAllCommittedTxns(org.apache.hadoop.hive.metastore.txn.TestAcidTxnCleanerService)
> Time elapsed: 9.952 s <<< FAILURE!
> 15:04:10 java.lang.AssertionError: expected:<6> but was:<7>
> 15:04:10 at
> org.apache.hadoop.hive.metastore.txn.TestAcidTxnCleanerService.cleansAllCommittedTxns(TestAcidTxnCleanerService.java:107)
> 15:04:10
> 15:04:10 [INFO]
> 15:04:10 [INFO] Results:
> 15:04:10 [INFO]
> 15:04:10 [ERROR] Failures:
> 15:04:10 [ERROR] TestAcidTxnCleanerService.cleansAllCommittedTxns:107
> expected:<6> but was:<7>
> 15:04:10 [INFO]
> 15:04:10 [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0
> 15:04:10 [INFO]
> 15:04:10 [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on
> project hive-standalone-metastore-server: There are test failures.
> 15:04:10 [ERROR]
> 15:04:10 [ERROR] Please refer to
> /home/jenkins/agent/workspace/hive-c/standalone-metastore/metastore-server/target/surefire-reports
> for the individual test results.
> 15:04:10 [ERROR] Please refer to dump files (if any exist)
> [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.
> 15:04:10 [ERROR] -> [Help 1]
> 15:04:10 [ERROR]
> 15:04:10 [ERROR] To see the full stack trace of the errors, re-run Maven
> with the -e switch.
> 15:04:10 [ERROR] Re-run Maven using the -X switch to enable full debug
> logging.
> 15:04:10 [ERROR]
> 15:04:10 [ERROR] For more information about the errors and possible
> solutions, please read the following articles:
> 15:04:10 [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
