[
https://issues.apache.org/jira/browse/HIVE-23807?focusedWorklogId=455537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455537
]
ASF GitHub Bot logged work on HIVE-23807:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/20 15:17
Start Date: 07/Jul/20 15:17
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on a change in pull request
#1212:
URL: https://github.com/apache/hive/pull/1212#discussion_r450945185
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java
##########
@@ -116,14 +118,16 @@ public void evaluate(VectorizedRowBatch batch) {
private void evaluate(LongColumnVector outV, BytesColumnVector inV, int i) {
String dateString = new String(inV.vector[i], inV.start[i], inV.length[i],
StandardCharsets.UTF_8);
- if (dateParser.parseDate(dateString, sqlDate)) {
+ try {
+ Date utilDate = Date.valueOf(dateString);
Review comment:
Yes this vectorized expression is generated for `GenericUDFDate`. I
don't see any way to trigger precommit job manually for branch-2. @kgyrtkirk
Do you know how can I trigger ptest for branch-2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455537)
Time Spent: 0.5h (was: 20m)
> Wrong results with vectorization enabled
> ----------------------------------------
>
> Key: HIVE-23807
> URL: https://issues.apache.org/jira/browse/HIVE-23807
> Project: Hive
> Issue Type: Bug
> Components: Vectorization
> Affects Versions: 2.3.0
> Reporter: Vineet Garg
> Assignee: Vineet Garg
> Priority: Major
> Labels: compatibility, pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *Repro*
> {code:sql}
> CREATE TABLE `test13`(
> `portfolio_valuation_date` string,
> `price_cut_off_datetime` string,
> `portfolio_id_valuation_source` string,
> `contributor_full_path` string,
> `position_market_value` double,
> `mandate_name` string)
> STORED AS ORC;
> INSERT INTO test13 values (
> "2020-01-31", "2020-02-07T03:14:48.007Z", "37", NULL, -0.26, "foo");
> INSERT INTO test13 values (
> "2020-01-31", "2020-02-07T03:14:48.007Z", "37", NULL, 0.33, "foo");
> INSERT INTO test13 values (
> "2020-01-31", "2020-02-07T03:14:48.007Z", "37", NULL, -0.03, "foo");
> INSERT INTO test13 values (
> "2020-01-31", "2020-02-07T03:14:48.007Z", "37", NULL, 0.16, "foo");
> INSERT INTO test13 values (
> "2020-01-31", "2020-02-07T03:14:48.007Z", "37", NULL, 0.08, "foo");
> set hive.fetch.task.conversion=none;
> set hive.explain.user=false;
> set hive.vectorized.execution.enabled=false;
> select Cast(`test13`.`price_cut_off_datetime` AS date) from test13; <--
> produces NULL
> set hive.vectorized.execution.enabled=true;
> select Cast(`test13`.`price_cut_off_datetime` AS date) from test13; <--
> produces non-null values
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
