[
https://issues.apache.org/jira/browse/HIVE-23638?focusedWorklogId=456062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456062
]
ASF GitHub Bot logged work on HIVE-23638:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/20 12:03
Start Date: 08/Jul/20 12:03
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1161:
URL: https://github.com/apache/hive/pull/1161#discussion_r451488767
##########
File path: common/src/java/org/apache/hadoop/hive/common/StringInternUtils.java
##########
@@ -135,10 +135,10 @@ public static Path internUriStringsInPath(Path path) {
public static <K> Map<K, String> internValuesInMap(Map<K, String> map) {
if (map != null) {
- for (K key : map.keySet()) {
- String value = map.get(key);
+ for (Map.Entry<K, String> entry : map.entrySet()) {
+ String value = entry.getValue();
if (value != null) {
- map.put(key, value.intern());
+ map.put(entry.getKey(), value.intern());
Review comment:
Nice idea! I followed similar logic to check if values are already
interned in all helper methods in StringInternUtils class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456062)
Time Spent: 1h 20m (was: 1h 10m)
> Fix FindBug issues in hive-common
> ---------------------------------
>
> Key: HIVE-23638
> URL: https://issues.apache.org/jira/browse/HIVE-23638
> Project: Hive
> Issue Type: Sub-task
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: spotbugsXml.xml
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> mvn -Pspotbugs
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugin.surefire.SurefirePlugin=INFO
> -pl :hive-common test-compile
> com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
