[
https://issues.apache.org/jira/browse/HIVE-23727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhihua Deng updated HIVE-23727:
-------------------------------
Comment: was deleted
(was: I'm wondering if we can improve the whole branch if (shouldRunAsync() &&
state != OperationState.CANCELED && state != OperationState.TIMEDOUT) here.
The codes here make some confusing to me, as state = OperationState.CLOSED will
be the only case that the canceling background will take effect, in this case
the operation may be finished, closed, failed, running(ctrl+c or session
timeout) or pended. There is no need to cancel the finished, closed, failed
operations, the running operations can be treated as the timeout operations,
which are cleaned up by driver::close.)
> Improve SQLOperation log handling when cleanup
> ----------------------------------------------
>
> Key: HIVE-23727
> URL: https://issues.apache.org/jira/browse/HIVE-23727
> Project: Hive
> Issue Type: Improvement
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The SQLOperation checks _if (shouldRunAsync() && state !=
> OperationState.CANCELED && state != OperationState.TIMEDOUT)_ to cancel the
> background task. If true, the state should not be OperationState.CANCELED, so
> logging under the state == OperationState.CANCELED should never happen.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
