[
https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=456468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456468
]
ASF GitHub Bot logged work on HIVE-23760:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 07:53
Start Date: 09/Jul/20 07:53
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1216:
URL: https://github.com/apache/hive/pull/1216#discussion_r452031376
##########
File path:
itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##########
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List<byte
[]> events) {
}
}
- public void createTopic(String topic) {
- int sessionTimeoutMs = 1000;
- ZkClient zkClient = new ZkClient(
- this.zkString, sessionTimeoutMs, sessionTimeoutMs,
- ZKStringSerializer$.MODULE$
- );
- ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString,
sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+ Properties properties = new Properties();
+ properties.setProperty("bootstrap.servers", "localhost:9092");
+ properties.setProperty("key.deserializer",
"org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the
line at the ',' instead of adding a new concatenation?
##########
File path:
itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##########
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List<byte
[]> events) {
}
}
- public void createTopic(String topic) {
- int sessionTimeoutMs = 1000;
- ZkClient zkClient = new ZkClient(
- this.zkString, sessionTimeoutMs, sessionTimeoutMs,
- ZKStringSerializer$.MODULE$
- );
- ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString,
sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+ Properties properties = new Properties();
+ properties.setProperty("bootstrap.servers", "localhost:9092");
+ properties.setProperty("key.deserializer",
"org.apache.kafka.common.serialization"
+ + ".StringDeserializer");
+
properties.setProperty("value.deserializer","org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the
line at the ',' instead of adding a new concatenation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456468)
Time Spent: 1h 40m (was: 1.5h)
> Upgrading to Kafka 2.5 Clients
> ------------------------------
>
> Key: HIVE-23760
> URL: https://issues.apache.org/jira/browse/HIVE-23760
> Project: Hive
> Issue Type: Improvement
> Components: kafka integration
> Reporter: Andras Katona
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
