[
https://issues.apache.org/jira/browse/HIVE-22957?focusedWorklogId=456536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456536
]
ASF GitHub Bot logged work on HIVE-22957:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 10:53
Start Date: 09/Jul/20 10:53
Worklog Time Spent: 10m
Work Description: shameersss1 commented on a change in pull request #1105:
URL: https://github.com/apache/hive/pull/1105#discussion_r452132752
##########
File path: itests/src/test/resources/testconfiguration.properties
##########
@@ -222,6 +222,7 @@ mr.query.files=\
mapjoin_subquery2.q,\
mapjoin_test_outer.q,\
masking_5.q,\
+ msck_repair_filter.q,\
Review comment:
Not a requirement though. This was done before we moved our qtests to
run on LLAP by default. It makes sense to move this to LLAP as well.
Fixed.
##########
File path: parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -1942,9 +1942,8 @@ metastoreCheck
@after { popMsg(state); }
: KW_MSCK (repair=KW_REPAIR)?
(KW_TABLE tableName
- ((add=KW_ADD | drop=KW_DROP | sync=KW_SYNC) (parts=KW_PARTITIONS))? |
- (partitionSpec)?)
- -> ^(TOK_MSCK $repair? tableName? $add? $drop? $sync? (partitionSpec*)?)
+ ((add=KW_ADD | drop=KW_DROP | sync=KW_SYNC) (parts=KW_PARTITIONS)
(filterPartitionSpec)?)?)
+ -> ^(TOK_MSCK $repair? tableName? $add? $drop? $sync?
(filterPartitionSpec)?)
Review comment:
Yes It makes sense!. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456536)
Time Spent: 1h 40m (was: 1.5h)
> Support Partition Filtering In MSCK REPAIR TABLE Command
> --------------------------------------------------------
>
> Key: HIVE-22957
> URL: https://issues.apache.org/jira/browse/HIVE-22957
> Project: Hive
> Issue Type: Improvement
> Reporter: Syed Shameerur Rahman
> Assignee: Syed Shameerur Rahman
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: Design Doc_ Partition Filtering In MSCK REPAIR
> TABLE.pdf, HIVE-22957.01.patch, HIVE-22957.02.patch, HIVE-22957.03.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> *Design Doc:*
> [^Design Doc_ Partition Filtering In MSCK REPAIR TABLE.pdf]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
