[
https://issues.apache.org/jira/browse/HIVE-23853?focusedWorklogId=459425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459425
]
ASF GitHub Bot logged work on HIVE-23853:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/20 17:26
Start Date: 15/Jul/20 17:26
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1256:
URL: https://github.com/apache/hive/pull/1256#discussion_r455213413
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -4206,6 +4206,10 @@ private static void copyFiles(final HiveConf conf, final
FileSystem destFs,
}
}
files = fileStatuses.toArray(new FileStatus[files.length]);
+
+ if (HiveConf.getBoolVar(conf,
HiveConf.ConfVars.HIVE_WRITE_ACID_VERSION_FILE)) {
+ AcidUtils.OrcAcidVersion.writeVersionFile(destf, destFs);
+ }
Review comment:
It was a my first try to have it in the FSOperator which I have forgot
to remove. After FSO we have like 3 moves which I wanted to avoid, so since we
already have a Compactor specific change in copyFiles, I have decided to reuse
it
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -25,9 +25,11 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
+import java.util.HashSet;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 459425)
Time Spent: 50m (was: 40m)
> CRUD based compaction also should update ACID file version metadata
> -------------------------------------------------------------------
>
> Key: HIVE-23853
> URL: https://issues.apache.org/jira/browse/HIVE-23853
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Current CRUD compaction does not update the file metadata to contain the ACID
> version. Also the {{_orc_acid_version}} version file is not created.
> We should do this to be consistent across the board.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
