[
https://issues.apache.org/jira/browse/HIVE-23835?focusedWorklogId=459714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459714
]
ASF GitHub Bot logged work on HIVE-23835:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/20 08:27
Start Date: 16/Jul/20 08:27
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1249:
URL: https://github.com/apache/hive/pull/1249#discussion_r454934068
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java
##########
@@ -217,6 +217,52 @@ public static void setNullSrcPath(HiveConf conf, boolean
aNullSrcPath) {
}
}
+
+ /**
+ * Wrapper class for mapping source and target path for copying function
binaries.
+ */
+ public static class FunctionBinaryCopyPath {
Review comment:
is this class any different from the table copy path. If not can we
reuse?
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestReplDumpTask.java
##########
@@ -87,7 +87,9 @@ String getValidTxnListForReplDump(Hive hiveDb, long
waitUntilTime) {
}
@Override
- void dumpFunctionMetadata(String dbName, Path dbMetadataRoot, Hive hiveDb)
{
+ List<EximUtil.FunctionBinaryCopyPath> dumpFunctionMetadata(String dbName,
Path dbMetadataRoot, Path dbDataRoot,
+ Hive hiveDb) {
Review comment:
do we dump function in case of metadata only replication?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 459714)
Time Spent: 20m (was: 10m)
> Repl Dump should dump function binaries to staging directory
> ------------------------------------------------------------
>
> Key: HIVE-23835
> URL: https://issues.apache.org/jira/browse/HIVE-23835
> Project: Hive
> Issue Type: Task
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23835.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:#172b4d}When hive function's binaries are on source HDFS, repl dump
> should dump it to the staging location in order to break cross clusters
> visibility requirement.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
