[
https://issues.apache.org/jira/browse/HIVE-23837?focusedWorklogId=459773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459773
]
ASF GitHub Bot logged work on HIVE-23837:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/20 11:17
Start Date: 16/Jul/20 11:17
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #1244:
URL: https://github.com/apache/hive/pull/1244#discussion_r455711625
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/MergeJoinWork.java
##########
@@ -66,6 +67,13 @@ public void replaceRoots(Map<Operator<?>, Operator<?>>
replacementMap) {
@Override
public void configureJobConf(JobConf job) {
+ for(Operator rootOp : getAllRootOperators()) {
Review comment:
I think, it can be extracted to base. In MapWork and ReduceWork , for
example, you can do same, at least for FileSinkOperator - iterate over
getAllRootOperators() and call configureJobConf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 459773)
Time Spent: 1h (was: 50m)
> HbaseStorageHandler is not configured properly when the FileSinkOperator is
> the child of a MergeJoinWork
> --------------------------------------------------------------------------------------------------------
>
> Key: HIVE-23837
> URL: https://issues.apache.org/jira/browse/HIVE-23837
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> If the FileSinkOperator's root operator is a MergeJoinWork the
> HbaseStorageHandler.configureJobConf will never get called, and the execution
> will miss the HBASE_AUTH_TOKEN and the hbase jars.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
