[
https://issues.apache.org/jira/browse/HIVE-23865?focusedWorklogId=459942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459942
]
ASF GitHub Bot logged work on HIVE-23865:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/20 20:40
Start Date: 16/Jul/20 20:40
Worklog Time Spent: 10m
Work Description: miklosgergely commented on a change in pull request
#1267:
URL: https://github.com/apache/hive/pull/1267#discussion_r456062008
##########
File path:
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java
##########
@@ -53,10 +54,10 @@ public static LazyBinaryStructObjectInspector
getLazyBinaryStructObjectInspector
public static LazyBinaryStructObjectInspector
getLazyBinaryStructObjectInspector(
List<String> structFieldNames,
List<ObjectInspector> structFieldObjectInspectors, List<String>
structFieldComments) {
- ArrayList<Object> signature = new ArrayList<Object>(3);
- signature.add(structFieldNames);
- signature.add(structFieldObjectInspectors);
- if(structFieldComments != null) {
+ List<Object> signature = structFieldComments == null ?
Arrays.asList(structFieldNames, structFieldObjectInspectors)
+ : Arrays.asList(structFieldNames, structFieldObjectInspectors,
structFieldComments);
+
+ if (structFieldComments != null) {
Review comment:
Isn't this a duplication? I mean if structFieldComments is not null, it
will be already in signature due to the command above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 459942)
Time Spent: 20m (was: 10m)
> Use More Java Collections Class
> -------------------------------
>
> Key: HIVE-23865
> URL: https://issues.apache.org/jira/browse/HIVE-23865
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
