[
https://issues.apache.org/jira/browse/HIVE-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907338#comment-14907338
]
Thejas M Nair commented on HIVE-11915:
--------------------------------------
Review comments -
- please remove the 2 imports that are no longer relevant to the change
- Change - LOG.error("BONECP returned a closed connection " +
e.getMessage()); to - LOG.warn("Error setting up new connection, getting
another connection from pool", e);
(the pool used might not be boncep; error might not be due to closed
connection; should be warn not error; and should indicate it is being retried;
full exception stack trace can be very useful).
- getConnAttemptCount = 10; Should we keep that generic and have it set to 10
in all cases and not bonecp specific ? It shouldn't hurt.
> BoneCP returns closed connections from the pool
> -----------------------------------------------
>
> Key: HIVE-11915
> URL: https://issues.apache.org/jira/browse/HIVE-11915
> Project: Hive
> Issue Type: Bug
> Reporter: Takahiko Saito
> Assignee: Sergey Shelukhin
> Attachments: HIVE-11915.01.patch, HIVE-11915.WIP.patch,
> HIVE-11915.patch
>
>
> It's a very old bug in BoneCP and it will never be fixed... There are
> multiple workarounds on the internet but according to responses they are all
> unreliable. We should upgrade to HikariCP (which in turn is only supported by
> DN 4), meanwhile try some shamanic rituals. In this JIRA we will try a
> relatively weak drum.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
