[
https://issues.apache.org/jira/browse/HIVE-23871?focusedWorklogId=460454&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-460454
]
ASF GitHub Bot logged work on HIVE-23871:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/20 18:22
Start Date: 17/Jul/20 18:22
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1273:
URL: https://github.com/apache/hive/pull/1273#discussion_r456603816
##########
File path: ql/src/test/queries/clientpositive/load_micromanaged_delim.q
##########
@@ -0,0 +1,32 @@
+set hive.support.concurrency=true;
+set hive.exec.dynamic.partition.mode=nonstrict;
+set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+
+
+dfs -mkdir ${system:test.tmp.dir}/delim_table;
+dfs -mkdir ${system:test.tmp.dir}/delim_table_ext;
+dfs -mkdir ${system:test.tmp.dir}/delim_table_trans;
+dfs -cp ${system:hive.root}/data/files/table1
${system:test.tmp.dir}/delim_table/;
+dfs -cp ${system:hive.root}/data/files/table1
${system:test.tmp.dir}/delim_table_ext/;
+dfs -cp ${system:hive.root}/data/files/table1
${system:test.tmp.dir}/delim_table_trans/;
+
+-- Checking that MicroManged and External tables have the same behaviour with
delimited input files
+-- External table
+CREATE EXTERNAL TABLE delim_table_ext(id INT, name STRING, safety INT) ROW
FORMAT DELIMITED FIELDS TERMINATED BY '\t' STORED AS TEXTFILE LOCATION
'${system:test.tmp.dir}/delim_table_ext/';
+describe formatted delim_table_ext;
+SELECT * FROM delim_table_ext;
+
+-- SET hive.create.as.acid=true
+-- SET hive.create.as.insert.only=true
Review comment:
Creates the same behaviour as the Table properties below but I agree it
makes sense to remove it
##########
File path: data/files/table1
##########
@@ -0,0 +1,5 @@
+1 Acura 4
Review comment:
sure, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 460454)
Time Spent: 0.5h (was: 20m)
> ObjectStore should properly handle MicroManaged Table properties
> ----------------------------------------------------------------
>
> Key: HIVE-23871
> URL: https://issues.apache.org/jira/browse/HIVE-23871
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: table1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIVE-23281 optimizes StorageDescriptor conversion as part of the ObjectStore
> by skipping particular Table properties like SkewInfo, bucketCols, ordering
> etc.
> However, it does that for all Transactional Tables – not only ACID – causing
> MicroManaged Tables to behave abnormally.
> MicroManaged (insert_only) tables may miss needed properties such as Storage
> Desc Params – that may define how lines are delimited (like in the example
> below):
> To repro the issue:
> {code:java}
> CREATE TRANSACTIONAL TABLE delim_table_trans(id INT, name STRING, safety INT)
> ROW FORMAT DELIMITED FIELDS TERMINATED BY '\t' STORED AS TEXTFILE;
> LOAD DATA INPATH 'table1' OVERWRITE INTO TABLE delim_table_trans;
> describe formatted delim_table_trans;
> SELECT * FROM delim_table_trans;
> {code}
> Result:
> {code:java}
> Table Type: MANAGED_TABLE
> Table Parameters:
> bucketing_version 2
> numFiles 1
> numRows 0
> rawDataSize 0
> totalSize 72
> transactional true
> transactional_properties insert_only
> #### A masked pattern was here ####
>
> # Storage Information
> SerDe Library: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
>
> InputFormat: org.apache.hadoop.mapred.TextInputFormat
> OutputFormat:
> org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
> Compressed: No
> Num Buckets: -1
> Bucket Columns: []
> Sort Columns: []
> PREHOOK: query: SELECT * FROM delim_table_trans
> PREHOOK: type: QUERY
> PREHOOK: Input: default@delim_table_trans
> #### A masked pattern was here ####
> POSTHOOK: query: SELECT * FROM delim_table_trans
> POSTHOOK: type: QUERY
> POSTHOOK: Input: default@delim_table_trans
> #### A masked pattern was here ####
> NULL NULL NULL
> NULL NULL NULL
> NULL NULL NULL
> NULL NULL NULL
> NULL NULL NULL
> NULL NULL NULL
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
