[
https://issues.apache.org/jira/browse/HIVE-23786?focusedWorklogId=461314&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461314
]
ASF GitHub Bot logged work on HIVE-23786:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/20 22:54
Start Date: 20/Jul/20 22:54
Worklog Time Spent: 10m
Work Description: sam-an-cloudera commented on a change in pull request
#1221:
URL: https://github.com/apache/hive/pull/1221#discussion_r457736948
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
##########
@@ -312,5 +578,13 @@ private String getCurrentUser() {
private String getCurrentUser(HiveMetaStoreAuthorizableEvent
authorizableEvent) {
return authorizableEvent.getAuthzContext().getUGI().getShortUserName();
}
+
+ private UserGroupInformation getUGI() {
+ try {
+ return UserGroupInformation.getCurrentUser();
+ } catch (IOException excp) {
Review comment:
Good catch. I didn't know we were just copy and pasting. Other codes
using getCurrentUser were either crashing or rethrow, so I've changed it to
throw, and more importantly, return false to the skipAuthorization call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 461314)
Time Spent: 3.5h (was: 3h 20m)
> HMS Server side filter
> ----------------------
>
> Key: HIVE-23786
> URL: https://issues.apache.org/jira/browse/HIVE-23786
> Project: Hive
> Issue Type: Improvement
> Reporter: Sam An
> Assignee: Sam An
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> HMS server side filter of results based on authorization.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
